Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement percentage node replacement for load balancer #1360

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Implement percentage node replacement for load balancer #1360

merged 5 commits into from
Aug 20, 2024
+54 −2

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Aug 15, 2024 •
edited
Loading

This is a hack to allow us to re-route a portion of traffic from an overloaded region to alternative nodes. We have a region where we'd like to balance more traffic away from onto alternative regions instead.

For example to re-route 25% of regionX to a selection of other nodes:

lb-replace-host-match = regionX
lb-replace-host-percent = 25
lb-replace-host-list = otherNode1,otherNode2

@mjh1
Implement percentage node replacement for load balancer
aebcee8 
This is a hack to allow us to re-route a portion of traffic from an overloaded region to alternative nodes
@mjh1 mjh1 requested a review from thomshutt August 15, 2024 17:10
@mjh1
Copy link
Contributor Author

mjh1 commented Aug 15, 2024 •
edited
Loading

Think I should be able to add some unit tests... one sec

@mjh1
Copy link
Contributor Author

mjh1 commented Aug 19, 2024

@thomshutt please could you review? thanks

@mjh1 mjh1 requested a review from leszko August 19, 2024 15:52
leszko
leszko approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjh1 could you add to the description the info "why are we doing it? 🙃

@mjh1
Copy link
Contributor Author

mjh1 commented Aug 20, 2024

Sure, I had meant the reason was that we need to re-route a portion of traffic from an overloaded region to alternative nodes

@mjh1 mjh1 merged commit 2632451 into main Aug 20, 2024
9 checks passed
@mjh1 mjh1 deleted the mh/node-replacement branch August 20, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszko leszko leszko approved these changes

@thomshutt thomshutt thomshutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjh1 @thomshutt @leszko